jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marcel Reutegger <mreut...@adobe.com>
Subject RE: svn commit: r1556779 - /jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/fixture/OakRepositoryFixture.java
Date Thu, 09 Jan 2014 15:00:18 GMT
> On Thu, Jan 9, 2014 at 5:31 AM,  <mreutegg@apache.org> wrote:
> > +                if (repo instanceof JackrabbitRepository) {
> > +                    ((JackrabbitRepository) repo).shutdown();
> > +                }
> 
> This looks ugly. It would be nice if the JCR repository wrapper around
>  was stateless, i.e. could simply be collected as normal garbage when
> no longer used.

yes, this would indeed be cleaner and require to revisit the changes
for OAK-941. those changes actually introduced the issue with a
scheduled executor that needs to be shut down.

regards
 marcel

Mime
View raw message