Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Received-SPF: pass (nike.apache.org: domain of julian.reschke@gmx.de
 designates 212.227.17.20 as permitted sender)
Message-ID: <52A5E529.6020807@gmx.de>
Date: Mon, 09 Dec 2013 16:43:37 +0100
From: Julian Reschke <julian.reschke@gmx.de>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.1.1
MIME-Version: 1.0
To: oak-dev@jackrabbit.apache.org
Subject: Re: clarification on _modCount / mongomk.md
References: <52A5E064.3020704@gmx.de>
 <9C0FC4C8E9C29945B01766FC7F9D389818A81562B0@eurmbx01.eur.adobe.com>
In-Reply-To: 
 <9C0FC4C8E9C29945B01766FC7F9D389818A81562B0@eurmbx01.eur.adobe.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 2013-12-09 16:29, Marcel Reutegger wrote:
> Hi,
>
>> I was trying to understand where support for _modCount actually happens.
>>
>> As far as I can tell, a DocumentStore implementation is free to use it
>> or not. The only non-MongoDocumentStore traces I could see is the string
>> constant in Document.java, right?
>
> this is correct. The JavaDoc for the field isn't really specific about this, but the
> return value of getModCount() is annotated with @CheckForNull, indicating
> that a Document may not have a mod count.

Right, forgot about that case.

As the use of MODCOUNT is somewhat internal to a DocumentStore impl, 
wouldn't it make sense to remove this signature and let the impls just 
to a regular Document.get(property)?

Best regards, Julian