jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chetan Mehrotra <chetan.mehro...@gmail.com>
Subject Re: Package deployment check for locking leading to large no of small branch commits
Date Wed, 18 Dec 2013 09:45:38 GMT
The patch works great!!

With patch applied I get similar timings as I got by disabling session
refresh in LockOperation.
Chetan Mehrotra


On Wed, Dec 18, 2013 at 2:47 PM, Michael Dürig <mduerig@apache.org> wrote:
>
>
> On 18.12.13 10:12 , Marcel Reutegger wrote:
>>>
>>> We could rebase the branch and then rebase the in memory changes on top
>>> of the rebased branch. This would get us rid of the branch commit. But
>>> wouldn't get us rid of the rebase operation on the persisted branch. So
>>> I'm not too sure this will gain us a lot.
>>
>>
>> hmm, you are right. this may still result in a commit on the branch for
>> the
>> rebase. it should be possible to avoid it when the rebase is actually a
>> no-op because there were no changes by other sessions.
>
>
> I think this is already the case. See
> org.apache.jackrabbit.oak.spi.state.AbstractNodeStoreBranch.Persisted#rebase
>
> For the other branch states rebasing is already entirely in memory. I
> quickly hacked together a POC patch for above approach. Chetan agreed to do
> a quick check with that.
>
> Michael
>
>>
>> Regards
>>   Marcel
>>
>

Mime
View raw message