Return-Path: X-Original-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5E8BD10694 for ; Fri, 1 Nov 2013 20:29:28 +0000 (UTC) Received: (qmail 34755 invoked by uid 500); 1 Nov 2013 20:29:28 -0000 Delivered-To: apmail-jackrabbit-oak-dev-archive@jackrabbit.apache.org Received: (qmail 34642 invoked by uid 500); 1 Nov 2013 20:29:27 -0000 Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-dev@jackrabbit.apache.org Received: (qmail 34634 invoked by uid 99); 1 Nov 2013 20:29:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Nov 2013 20:29:27 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jukka.zitting@gmail.com designates 209.85.219.43 as permitted sender) Received: from [209.85.219.43] (HELO mail-oa0-f43.google.com) (209.85.219.43) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Nov 2013 20:29:22 +0000 Received: by mail-oa0-f43.google.com with SMTP id m1so5084245oag.16 for ; Fri, 01 Nov 2013 13:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=CZ9HpgbTtzNJAJpU/yZX8A97GTkhI2RYFSHuS2+TziA=; b=Fz2vTdl46FFslnmWy3sWT/nLYk9w1Hh2UBG7/SlDgD1a9LaqLHS6SXCiaJFwcyRBAq 0Q+FFutTqEuYSmaIUufbgkcn/bICRkGIE+G726uxg9q+7z63gnS+9d8wFhiGZVl1EAMc fIOrbv3ofoAwSX9as6V9lbsbMJqSftYTWtXtlAjEu05gPOUK4XkPM42zB2m6zMSCVGte MQnwKePAMt6Yg2/IHGunaQ+hUk9H+w9ZYpdSUYYaf3W6S9bKLU6fPtp3EDE9VEpRxeTZ sCt5QJAApqTiLZ7bufLtorhwcZcbQTtE7DdHl4DDTZcsQHpeyct9cxaLpZF63XXwhyNq JdEg== X-Received: by 10.60.39.169 with SMTP id q9mr1816862oek.79.1383337741757; Fri, 01 Nov 2013 13:29:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.115.67 with HTTP; Fri, 1 Nov 2013 13:28:41 -0700 (PDT) From: Jukka Zitting Date: Fri, 1 Nov 2013 16:28:41 -0400 Message-ID: Subject: Optimizations in and around SecureNodeBuilder To: Oak devs Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org Hi, I spent this afternoon looking at SecureNodeBuilder with the goal to fix potential bugs and reduce the amount of duplicate work that's going on. I explicitly avoided touching the actual permission evaluation as Angela and Toby are already working on it, but I was still able to identify and fix a number of issues. See issues from OAK-1139 to OAK-1142 for details. The result of these changes is a nice performance boost. We're still slower than Jackrabbit 2.x for the GetNodeWithAnonymous benchmark, but the performance difference has dropped from 3x to just above 2x. # GetNodeWithAnonymous C min 10% 50% 90% max N Oak-Tar (before) 1 58 59 60 61 100 991 Oak-Tar (after) 1 42 42 43 45 130 1372 Jackrabbit 1 18 19 19 20 39 3087 BR, Jukka Zitting