Return-Path: X-Original-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BD69B105C2 for ; Wed, 16 Oct 2013 07:22:49 +0000 (UTC) Received: (qmail 94530 invoked by uid 500); 16 Oct 2013 07:22:46 -0000 Delivered-To: apmail-jackrabbit-oak-dev-archive@jackrabbit.apache.org Received: (qmail 94391 invoked by uid 500); 16 Oct 2013 07:22:45 -0000 Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-dev@jackrabbit.apache.org Received: (qmail 94364 invoked by uid 99); 16 Oct 2013 07:22:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Oct 2013 07:22:45 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy includes SPF record at spf.trusted-forwarder.org) Received: from [64.18.1.78] (HELO exprod6og127.obsmtp.com) (64.18.1.78) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Oct 2013 07:22:37 +0000 Received: from outbound-smtp-1.corp.adobe.com ([192.150.11.134]) by exprod6ob127.postini.com ([64.18.5.12]) with SMTP ID DSNKUl4+p1ukvPdzspC9dufGWTt1/0a3x78c@postini.com; Wed, 16 Oct 2013 00:22:16 PDT Received: from inner-relay-1.corp.adobe.com ([153.32.1.51]) by outbound-smtp-1.corp.adobe.com (8.12.10/8.12.10) with ESMTP id r9G7IaiH028774 for ; Wed, 16 Oct 2013 00:18:36 -0700 (PDT) Received: from nacas03.corp.adobe.com (nacas03.corp.adobe.com [10.8.189.121]) by inner-relay-1.corp.adobe.com (8.12.10/8.12.10) with ESMTP id r9G7L66J015065 for ; Wed, 16 Oct 2013 00:22:14 -0700 (PDT) Received: from SJ1GWM332.corp.adobe.com (10.5.79.97) by nacas03.corp.adobe.com (10.8.189.121) with Microsoft SMTP Server (TLS) id 8.3.327.1; Wed, 16 Oct 2013 00:21:54 -0700 Received: from eurcas01.eur.adobe.com (10.128.4.27) by SJ1GWM332.corp.adobe.com (10.5.79.97) with Microsoft SMTP Server (TLS) id 14.3.158.1; Wed, 16 Oct 2013 00:21:54 -0700 Received: from [10.132.1.214] (10.132.1.214) by eurcas01.eur.adobe.com (10.128.4.111) with Microsoft SMTP Server id 8.3.327.1; Wed, 16 Oct 2013 08:21:51 +0100 Message-ID: <525E3EA2.6040506@apache.org> Date: Wed, 16 Oct 2013 09:22:10 +0200 From: =?UTF-8?B?TWljaGFlbCBEw7xyaWc=?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Subject: Re: svn commit: r1532157 - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/NodeTypeImpl.java oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/nodetype/NodeTypeEqualsTest.java References: <20131015004222.5EA6B23889ED@eris.apache.org> <525CF38E.3060208@apache.org> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On 15.10.13 8:04 , Tobias Bocanegra wrote: > I think the semantics of NodeType.equals() should be mentioned in the JCR > API. I'm indifferent if we should consider the comparison between 2 > different implementations. The symmetry requirement comes from the general contract of equals and we can't specify this away. Its a tough requirement to get right across inheritance. That's why I'd prefer to not take inheritance into account and simply return false for NodeType.equals() between different implementations. The current implementation would still return true for n.equals(m) but might return false for m.equals(n) if getCnd(m).equals(getCnd(n)) and n instanceOf NodeTypeImpl and !(m instanceOf NodeTypeImpl). Michael