Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Received-SPF: pass (nike.apache.org: domain of chetan.mehrotra@gmail.com
 designates 209.85.219.47 as permitted sender)
MIME-Version: 1.0
Date: Thu, 12 Sep 2013 10:26:14 +0530
Message-ID: 
 <CAHCW-mkwnAkwU8yujntAp7vYjYUfnS7CYBBeSPCuWvdEt303qQ@mail.gmail.com>
Subject: Providing details with CommitFailedException and security
 considerations
From: Chetan Mehrotra <chetan.mehrotra@gmail.com>
To: oak-dev@jackrabbit.apache.org
Content-Type: text/plain; charset=ISO-8859-1

Hi,

As part of OAK-943 I had updated the ConflictValidator [1] to more
more details around Commit Failure. However exposing such details as
part of exception was considered risky from security aspect and it was
decided to log a warning instead.

Now in some cases the upper layer do expect a CommitFailedException
have required logic to retry the commit in case of failure. In such
cases these warning logs cause confusion.

So not sure what is the best thing to do. Should I turn the log to
debug level or make details part of exception message?

Making it part of warn level would cause issue as such situations a
not very repetative and users typically run system at INFO level.

If I make it part of exception message is then max it would expose
presence of some property names (not there values). And in most cases
the exception is not exposed to end user and is logged to system logs.
So probably we can make it part of exception message itself


[1] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/commit/ConflictValidator.java#L90

Chetan Mehrotra