jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Angela Schreiber <anch...@adobe.com>
Subject Workspace#copy with referenceable nodes
Date Thu, 26 Sep 2013 09:01:37 GMT
hi devs

i just came across the fix of OAK-915 (Workspace#copy of referenceable
nodes does not generate new UUIDs), which performs the following
in oak-jcr:

1) Root#copy
2) Traverse the tree and set new jcr:uuid properties
3) Update references

IMO this fix is not correct and will not work because it's not built
on the nodestate level. The latest root used for the copy will
only see those items accessible to the editing session (i.e. permission
constraints are enforced).

similarly the editing session is not guaranteed to see all (weak)
reference properties in the copied subtree and again the contract
defined by the specification cannot be met.

what is needed IMO is a low-level copy within the Root#copy call
which can get access to all jcr:uuid properties and all (weak) references
present in the copied tree.

the original issue has already been closed and cannot be reopened.
however, IMO this is a major issue that will break existing code.


View raw message