jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig <mdue...@apache.org>
Subject Re: svn commit: r1518048 - in /jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr: NodeImpl.java delegate/NodeDelegate.java lock/LockImpl.java lock/LockManagerImpl.java lock/LockOperation.java
Date Wed, 11 Sep 2013 09:19:18 GMT

Jukka,

On 28.8.13 3:33 , jukka@apache.org wrote:
> Author: jukka
> Date: Wed Aug 28 01:33:21 2013
> New Revision: 1518048
>
> URL: http://svn.apache.org/r1518048
> Log:
> OAK-150: Basic JCR LockManager support

...

>
>       @Override
> +    public boolean isRefresh() {
> +        return true;
> +    }
> +


What is the reason for returning true here? Only operations that refresh 
the session should return true here. If returning true is necessary 
here, you might be exploiting a side effect and we should try to come up 
with a more explicit solution.

Michael

Mime
View raw message