Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Received-SPF: pass (nike.apache.org: domain of jukka.zitting@gmail.com
 designates 209.85.214.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAB-0WTA4+ewfQ2LRiZyWPGVSC5=_swN8s=EfKmpWKP62ypvZyQ@mail.gmail.com>
References: 
 <CAB-0WTA4+ewfQ2LRiZyWPGVSC5=_swN8s=EfKmpWKP62ypvZyQ@mail.gmail.com>
From: Jukka Zitting <jukka.zitting@gmail.com>
Date: Wed, 5 Jun 2013 15:43:23 +0300
Message-ID: 
 <CAOFYJNa_Sxz=BOAETqBqMCy9CyFZgf1+2M49qPxV7CZ0aBT=DA@mail.gmail.com>
Subject: Re: NodeBuilder#setProperty using the same value
To: Oak devs <oak-dev@jackrabbit.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

Hi,

On Wed, Jun 5, 2013 at 3:32 PM, Alex Parvulescu
<alex.parvulescu@gmail.com> wrote:
> I'm wondering if we could turn the NodeBuilder#setProperty into a noop when
> setting the same value on a property.

I don't see any bigger issues with this, though it would be nice to
have a benchmark that verifies that the added complexity (though small
in this case) is worth it.

Note that such no-op changes are currently in any case filtered out
when producing the JSOP diff that's then passed to the underlying
MicroKernel. And the SegmentMK uses other means of detecting and
unifying duplicate content.

BR,

Jukka Zitting