jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jukka Zitting <jukka.zitt...@gmail.com>
Subject Re: NodeBuilder#setProperty using the same value
Date Wed, 05 Jun 2013 12:43:23 GMT

On Wed, Jun 5, 2013 at 3:32 PM, Alex Parvulescu
<alex.parvulescu@gmail.com> wrote:
> I'm wondering if we could turn the NodeBuilder#setProperty into a noop when
> setting the same value on a property.

I don't see any bigger issues with this, though it would be nice to
have a benchmark that verifies that the added complexity (though small
in this case) is worth it.

Note that such no-op changes are currently in any case filtered out
when producing the JSOP diff that's then passed to the underlying
MicroKernel. And the SegmentMK uses other means of detecting and
unifying duplicate content.


Jukka Zitting

View raw message