Return-Path: X-Original-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A1487DBF7 for ; Tue, 21 May 2013 08:25:59 +0000 (UTC) Received: (qmail 42969 invoked by uid 500); 21 May 2013 08:26:00 -0000 Delivered-To: apmail-jackrabbit-oak-dev-archive@jackrabbit.apache.org Received: (qmail 42918 invoked by uid 500); 21 May 2013 08:25:59 -0000 Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-dev@jackrabbit.apache.org Received: (qmail 42881 invoked by uid 99); 21 May 2013 08:25:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 May 2013 08:25:59 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jukka.zitting@gmail.com designates 209.85.219.45 as permitted sender) Received: from [209.85.219.45] (HELO mail-oa0-f45.google.com) (209.85.219.45) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 May 2013 08:25:54 +0000 Received: by mail-oa0-f45.google.com with SMTP id j6so434103oag.32 for ; Tue, 21 May 2013 01:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=aYTYO9XdwjmmPUSmwSeaQNayFUvMA/yrvJc1Mzrlbdg=; b=ppfcyo4yscO0OF3C1ePuz9cjTtEVbMsGfjiLZ4hm4fuEAR2jviP+JPUSAy/HPXD6Xm aOOu16i83k2oEl2ESf+KvMTPARKKaidpD0lnuukUlgCRLGg4V3uJbKqDFKSu2narHJ92 n0XxliCSsoVFqahkOoM/yzUg8fJhSdx3c3oZGXGbnD3htB4sAXDahJMK9seHy9h6LxBZ M41bHAMz7cQvOX2S7MDHentVzYyafYPojqWx8KBZH0b3e4mw0tJR71kgJmDkgoe3+qEM 7+vuKgNdhUmusnzdp+pPeysoMQcoJA2a3HCD3E1WWq7Hj9e+Yr+8D7MpoH1KN2Lhw1IN x+Rw== X-Received: by 10.182.213.105 with SMTP id nr9mr683869obc.78.1369124733584; Tue, 21 May 2013 01:25:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.61.44 with HTTP; Tue, 21 May 2013 01:25:13 -0700 (PDT) In-Reply-To: <20130520093243.376112388906@eris.apache.org> References: <20130520093243.376112388906@eris.apache.org> From: Jukka Zitting Date: Tue, 21 May 2013 11:25:13 +0300 Message-ID: Subject: Re: svn commit: r1484405 - in /jackrabbit/oak/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene: LuceneIndex.java LuceneIndexConstants.java LuceneIndexUpdate.java util/LuceneIndexHelper.java util/LuceneInitializerHelper.java To: Oak devs Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org Hi, On Mon, May 20, 2013 at 12:32 PM, wrote: > + for (String p : root.split("/")) { > + rootf = new File(rootf, p); > + } BTW, if any of the path components contain a prefixed name like jcr:system, the resulting File instance won't work on Windows. More generally the path components probably need to be escaped somehow as the set of valid OS filenames is different from those of valid Oak names. Even things like the distinction between upper and lower case names may be different. BR, Jukka Zitting