Return-Path: X-Original-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E847BF348 for ; Thu, 28 Mar 2013 15:20:20 +0000 (UTC) Received: (qmail 62349 invoked by uid 500); 28 Mar 2013 15:20:20 -0000 Delivered-To: apmail-jackrabbit-oak-dev-archive@jackrabbit.apache.org Received: (qmail 62112 invoked by uid 500); 28 Mar 2013 15:20:16 -0000 Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-dev@jackrabbit.apache.org Received: (qmail 62074 invoked by uid 99); 28 Mar 2013 15:20:15 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Mar 2013 15:20:15 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of anchela@adobe.com designates 64.18.1.39 as permitted sender) Received: from [64.18.1.39] (HELO exprod6og117.obsmtp.com) (64.18.1.39) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Mar 2013 15:20:06 +0000 Received: from outbound-smtp-2.corp.adobe.com ([193.104.215.16]) by exprod6ob117.postini.com ([64.18.5.12]) with SMTP ID DSNKUVRfkCcVmc4PCy9+JzAc0hMvsgsvEsuC@postini.com; Thu, 28 Mar 2013 08:19:45 PDT Received: from inner-relay-1.corp.adobe.com (inner-relay-1.sea.adobe.com [153.32.1.51]) by outbound-smtp-2.corp.adobe.com (8.12.10/8.12.10) with ESMTP id r2SFJg2h027620 for ; Thu, 28 Mar 2013 08:19:43 -0700 (PDT) Received: from nacas01.corp.adobe.com (nacas01.corp.adobe.com [10.8.189.99]) by inner-relay-1.corp.adobe.com (8.12.10/8.12.10) with ESMTP id r2SFJgAV017609 for ; Thu, 28 Mar 2013 08:19:42 -0700 (PDT) Received: from eurhub01.eur.adobe.com (10.128.4.30) by nacas01.corp.adobe.com (10.8.189.99) with Microsoft SMTP Server (TLS) id 8.3.298.1; Thu, 28 Mar 2013 08:19:42 -0700 Received: from angela.corp.adobe.com (10.132.1.7) by eurhub01.eur.adobe.com (10.128.4.111) with Microsoft SMTP Server id 8.3.298.1; Thu, 28 Mar 2013 15:19:39 +0000 Message-ID: <51545F8A.9020500@adobe.com> Date: Thu, 28 Mar 2013 16:19:38 +0100 From: Angela Schreiber User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11 MIME-Version: 1.0 To: Subject: Re: Some more benchmarks References: <5154505F.50207@apache.org> In-Reply-To: <5154505F.50207@apache.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org hi michael > With the resolution of OAK-690, I made tree instances stable across save > and refresh operations. does that mean that the AuthorizableImpl could hold a Tree instance instead of re-accessing it over and over again using a lookup by id? if that was the case, could you please create an issue asking for that refactoring such that we don't forget it? the fix should be fairly trivial as the Tree gets passed to the constructor for validation but is currently not kept as field. regards angela