Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Received-SPF: pass (athena.apache.org: domain of anchela@adobe.com designates
 64.18.1.39 as permitted sender)
Message-ID: <51488F39.6090005@adobe.com>
Date: Tue, 19 Mar 2013 17:15:53 +0100
From: Angela Schreiber <anchela@adobe.com>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US;
 rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11
MIME-Version: 1.0
To: <oak-dev@jackrabbit.apache.org>
Subject: Re: svn commit: r1458234 - in /jackrabbit/oak/trunk:
 oak-core/src/main/java/org/apache/jackrabbit/oak/core/
 oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/
 oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/version/
 oak-core/src/main/java/o
References: 
 <9C0FC4C8E9C29945B01766FC7F9D3898178B1A68D8@eurmbx01.eur.adobe.com>
 <51487168.6050906@adobe.com>
 <9C0FC4C8E9C29945B01766FC7F9D3898178BA0F7B3@eurmbx01.eur.adobe.com>
In-Reply-To: 
 <9C0FC4C8E9C29945B01766FC7F9D3898178BA0F7B3@eurmbx01.eur.adobe.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

hi marcel

On 3/19/13 4:09 PM, Marcel Reutegger wrote:
>> right... but i don't see why we have to recalculate the path
>> when the node states already know about them and we usually
>> do know the path of an immutable tree because we have
>> traversed to there using the TreeLocations.
>
> the problem is, only the KernelNodeState knows about its path,
> but none of the other five classes implementing NodeState do.
>
>> IMO we should have NodeState#getPath but as long as we don't
>> have that i will need sort of workaround to have an efficient
>> way to handle ImmutableTree#getPath.
>
> AFAIU, NodeState was specifically designed to not require a path.
>
> how about caching the path in ImmutableTree? IIUC this tree
> implementation works on top of NodeStates, which means the
> path will never change, right?

we had that already in a previous version but it got reverted.
i can live with any solution as long as the path is not
calculated when it's actually known already.

kind regards
angela

> Regards
>   Marcel