jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marcel Reutegger <mreut...@adobe.com>
Subject RE: svn commit: r1458234 - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/core/ oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/ oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/version/ oak-core/src/main/java/o
Date Tue, 19 Mar 2013 15:09:55 GMT
> right... but i don't see why we have to recalculate the path
> when the node states already know about them and we usually
> do know the path of an immutable tree because we have
> traversed to there using the TreeLocations.

the problem is, only the KernelNodeState knows about its path,
but none of the other five classes implementing NodeState do.

> IMO we should have NodeState#getPath but as long as we don't
> have that i will need sort of workaround to have an efficient
> way to handle ImmutableTree#getPath.

AFAIU, NodeState was specifically designed to not require a path.

how about caching the path in ImmutableTree? IIUC this tree
implementation works on top of NodeStates, which means the
path will never change, right?

View raw message