Return-Path: X-Original-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EC2B6E98B for ; Mon, 25 Feb 2013 14:46:09 +0000 (UTC) Received: (qmail 35288 invoked by uid 500); 25 Feb 2013 14:46:09 -0000 Delivered-To: apmail-jackrabbit-oak-dev-archive@jackrabbit.apache.org Received: (qmail 35062 invoked by uid 500); 25 Feb 2013 14:46:03 -0000 Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-dev@jackrabbit.apache.org Received: (qmail 35005 invoked by uid 99); 25 Feb 2013 14:46:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Feb 2013 14:46:02 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jukka.zitting@gmail.com designates 209.85.214.174 as permitted sender) Received: from [209.85.214.174] (HELO mail-ob0-f174.google.com) (209.85.214.174) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Feb 2013 14:45:54 +0000 Received: by mail-ob0-f174.google.com with SMTP id 16so2890226obc.19 for ; Mon, 25 Feb 2013 06:45:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=rc4EMnqeEC8F8FHwgvfLZea4RFRb8Wn4PCkXer3Kp08=; b=RVjP4UA5XJwU9mLt9iLPlLXEPOkani7vuwM9jpjxlbUKLgAdQ0jJh9/NI93swAp5d0 LjVAtP/pMaWmg46zZDZ1OWTo1BtN5c2h7xhe2vufL54IZlSvkslhrUzpY9V91SEyrBAg aU4QnoSb02yd0YkGA9Cdlcvrf3y0Dend439JDCv18iz8k+G9xuExliam5esBVIKhuxQW AP5Li3sfk25gJFKnW11tNgsgmb6ZwQoohIOl2DkG+MtIR6AlWiS8BAtELdmnPylkrzs0 9bStuFA/hE4rtpGuRHSJmnUeuY1ZqhLcWk1vZ0x16QNzr9wVHzwjiz/7fmSsLT1lQ+wS sslA== X-Received: by 10.60.31.79 with SMTP id y15mr7976211oeh.123.1361803533575; Mon, 25 Feb 2013 06:45:33 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.132.20 with HTTP; Mon, 25 Feb 2013 06:45:13 -0800 (PST) In-Reply-To: References: From: Jukka Zitting Date: Mon, 25 Feb 2013 16:45:13 +0200 Message-ID: Subject: Re: Dropping ItemImpl.checkPropertected() To: Oak devs Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org Hi, On Mon, Feb 25, 2013 at 3:17 PM, Jukka Zitting wrote: > Thoughts on this? Unless anyone has strong objections, I'd suggest we > simply drop the checkProtected() calls and have the relevant > constraints enforced during save(). I filed https://issues.apache.org/jira/browse/OAK-652 to track the implementation of whichever consensus we find on this, to remore or to optimize the checkProtected() call. Meanwhile I'll add a temporary feature flag to allow further benchmarking without having this issue mask other potential problems. BR, Jukka Zitting