Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Received-SPF: pass (athena.apache.org: domain of jukka.zitting@gmail.com
 designates 209.85.214.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAB-0WTDqw_+h2OaK0WEgdiBki5nht+07EdQdafZJtQqM9am3LQ@mail.gmail.com>
References: 
 <CAOFYJNZr-Xko+-hpwfW2WwCdjO7MNeweJMDEgNV+pdPsANaq1g@mail.gmail.com>
 <4C2FF119-6C19-4E46-BF8B-4164A6C13132@adobe.com>
 <CAB-0WTDss5UsgcHJEnpzVg=g7BSFA4-A9rxdDN5n0ke=r=2jyQ@mail.gmail.com>
 <CAB-0WTDqw_+h2OaK0WEgdiBki5nht+07EdQdafZJtQqM9am3LQ@mail.gmail.com>
From: Jukka Zitting <jukka.zitting@gmail.com>
Date: Fri, 22 Feb 2013 14:20:14 +0200
Message-ID: 
 <CAOFYJNYy=-=H_FokqJtS8dPxr7iS2V7fsipmZyEUq-g_KBe_1Q@mail.gmail.com>
Subject: Re: One hook to rule them all
To: Oak devs <oak-dev@jackrabbit.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

Hi,

On Fri, Feb 22, 2013 at 11:28 AM, Alex Parvulescu
<alex.parvulescu@gmail.com> wrote:
> I almost had this going until I ran into some CommitHooks that deviate from
> this standard behavior (like the ValidatingHook for ex which needs a root
> validator)

Actually you could think of the ValidatingHook as a variant of your
approach, as it also maintains a set of diff objects (Validator is
much like NodeStateDiff). The main difference to the index hook
mechanism is that validators can't modify the content tree.

I'm hoping to come up with an approach that could generalize and merge
these features into one hook.

BR,

Jukka Zitting