jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Parvulescu <alex.parvule...@gmail.com>
Subject Re: AbstractNodeState strange loop
Date Tue, 19 Feb 2013 15:37:36 GMT
hi,

> I don't believe we'll be seeing too many new NodeState implementations
anymore.

I could have said the same thing a few weeks ago, but then the segmentmk
was born :)

I'll followup with an issue to drop the getChildNodeEntries method - that
seems easiest.

thanks,
alex


On Tue, Feb 19, 2013 at 4:21 PM, Jukka Zitting <jukka.zitting@gmail.com>wrote:

> Hi,
>
> On Tue, Feb 19, 2013 at 5:18 PM, Alex Parvulescu
> <alex.parvulescu@gmail.com> wrote:
> > Dropping the one that I suggested (#getChildNodeEntries) has a really low
> > footprint as all subclasses have already implemented it.
> > Future NodeState implementations that extend from ANS need to be aware of
> > this tiny gem in the code. The least we could do is add a warning in the
> > javadocs.
>
> I'm fine with whatever you consider best. As you mention, those parts
> of ANS are no longer needed and I don't believe we'll be seeing too
> many new NodeState implementations anymore.
>
> BR,
>
> Jukka Zitting
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message