jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Parvulescu <alex.parvule...@gmail.com>
Subject Re: How should the current Tree and NodeState apis behave in the case of a null child name?
Date Tue, 19 Feb 2013 11:03:42 GMT
> Null doesn't make any sense there, so I'd consider it invalid

Perfect, see attached patch on OAK-635. I used a combo of @Nonnull and
checkNotNull
to enforce this constraint.

alex

On Tue, Feb 19, 2013 at 10:22 AM, Michael Dürig <michid@gmail.com> wrote:

> +1
> Michael
> On Feb 19, 2013 9:20 AM, "Jukka Zitting" <jukka.zitting@gmail.com> wrote:
>
> > Hi,
> >
> > On Tue, Feb 19, 2013 at 11:14 AM, Alex Parvulescu
> > <alex.parvulescu@gmail.com> wrote:
> > > I'm looking at the Tree and the NodeState interfaces, I see a lot of
> api
> > > docs about the returned value but no constraints about the input child
> > name.
> > > Is null considered a valid input?
> >
> > Null doesn't make any sense there, so I'd consider it invalid. Empty
> > strings should probably be treated equally.
> >
> > BR,
> >
> > Jukka Zitting
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message