From oak-dev-return-3199-apmail-jackrabbit-oak-dev-archive=jackrabbit.apache.org@jackrabbit.apache.org Wed Jan 9 10:29:19 2013 Return-Path: X-Original-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 83ECDE9D7 for ; Wed, 9 Jan 2013 10:29:19 +0000 (UTC) Received: (qmail 53526 invoked by uid 500); 9 Jan 2013 10:29:12 -0000 Delivered-To: apmail-jackrabbit-oak-dev-archive@jackrabbit.apache.org Received: (qmail 52802 invoked by uid 500); 9 Jan 2013 10:29:11 -0000 Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-dev@jackrabbit.apache.org Received: (qmail 51996 invoked by uid 99); 9 Jan 2013 10:29:10 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jan 2013 10:29:10 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of mreutegg@adobe.com designates 64.18.1.181 as permitted sender) Received: from [64.18.1.181] (HELO exprod6og101.obsmtp.com) (64.18.1.181) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jan 2013 10:29:01 +0000 Received: from outbound-smtp-1.corp.adobe.com ([192.150.11.134]) by exprod6ob101.postini.com ([64.18.5.12]) with SMTP ID DSNKUO1GWGLRlxvWRp53Ht7ONrQ0AUvE86fA@postini.com; Wed, 09 Jan 2013 02:28:40 PST Received: from inner-relay-1.corp.adobe.com ([153.32.1.51]) by outbound-smtp-1.corp.adobe.com (8.12.10/8.12.10) with ESMTP id r09APg1v008893 for ; Wed, 9 Jan 2013 02:25:42 -0800 (PST) Received: from nahub02.corp.adobe.com (nahub02.corp.adobe.com [10.8.189.98]) by inner-relay-1.corp.adobe.com (8.12.10/8.12.10) with ESMTP id r09ASdAV007044 for ; Wed, 9 Jan 2013 02:28:40 -0800 (PST) Received: from eurcas01.eur.adobe.com (10.128.4.27) by nahub02.corp.adobe.com (10.8.189.98) with Microsoft SMTP Server (TLS) id 8.3.297.1; Wed, 9 Jan 2013 02:28:39 -0800 Received: from eurmbx01.eur.adobe.com ([10.128.4.32]) by eurcas01.eur.adobe.com ([10.128.4.27]) with mapi; Wed, 9 Jan 2013 10:28:38 +0000 From: Marcel Reutegger To: "oak-dev@jackrabbit.apache.org" Date: Wed, 9 Jan 2013 10:28:36 +0000 Subject: RE: MongoMK: CommitCommandInstructionVisitor Thread-Topic: MongoMK: CommitCommandInstructionVisitor Thread-Index: Ac3uUtBizMXooRJySrSY4N/BA4ShFwAASA2Q Message-ID: <9C0FC4C8E9C29945B01766FC7F9D3898173DA4955C@eurmbx01.eur.adobe.com> References: <9C0FC4C8E9C29945B01766FC7F9D3898173DA4954A@eurmbx01.eur.adobe.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org > I guess this makes sense, although I'm curious what MicroKernelIT tests > would fail if we simply change headRevisionId in > CommitCommandInstructionVisitor to baseRevisionId of Commit. I'll try that out. > I'm thinking > about the case where the passed in revision id is null and also other > cases where there are conflicting moves/adds/deletes. I think in this case we'd still use the head revision. regards marcel