jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Angela Schreiber <anch...@adobe.com>
Subject Regarding NullLocation#getParent (was Re: svn commit: r1440930)
Date Thu, 31 Jan 2013 13:08:34 GMT
hi michael

while looking at the TreeLocation implementation was wondering about
NullLocation#getParent() as IMO it violates the API contract because
it always returns the NULL-location. is there a particular reason
for this? and wouldn't it be possible to return the original
parent location through which this NULL location had originally
be accessed? to me that would feel much more natural that having
a location that all in a sudden is isolated from the hierarchy.

what do you think?

regards
angela

> +    /**
> +     * @return  {@code NULL}
> +     */
> +    @Override
> +    public TreeLocation getParent() {
> +        return NULL;
> +    }


Mime
View raw message