Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Received-SPF: pass (nike.apache.org: domain of jukka.zitting@gmail.com
 designates 209.85.220.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <50C745C1.5050206@apache.org>
References: <20121211125753.1FD07238890B@eris.apache.org>
 <50C745C1.5050206@apache.org>
From: Jukka Zitting <jukka.zitting@gmail.com>
Date: Tue, 11 Dec 2012 17:02:09 +0200
Message-ID: 
 <CAOFYJNa4JfFisjB47UM_LSchvHg2RG+SKtO_XkPbhSVfEerbiQ@mail.gmail.com>
Subject: Re: svn commit: r1420138 - in
 /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak:
 query/ query/ast/ query/index/ spi/query/
To: Oak devs <oak-dev@jackrabbit.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Dec 11, 2012 at 4:40 PM, Michael D=FCrig <mduerig@apache.org> wrote=
:
> On 11.12.12 12:57, thomasm@apache.org wrote:
>> -    private Root root;
>> +    private Root rootTree;
>
> I'd leave these at root and only use rootTree for variables of type Tree,
> which hold the root node of a tree (i.e. Tree rootTree =3D root.getTree("=
/")).

Could we refactor the code so that the QueryEngine instance doesn't
need a direct Root reference? I.e. it would only have a reference to
the root Tree of the current repository snapshot. AFAICT the query
engine only needs the Root to be able to look up Tree instances, much
less than the commit/refresh/etc. functionality offered by Root.

BR,

Jukka Zitting