jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Angela Schreiber <anch...@adobe.com>
Subject Re: svn commit: r1418316 - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/api/ oak-core/src/main/java/org/apache/jackrabbit/oak/core/ oak-core/src/main/java/org/apache/jackrabbit/oak/namepath/ oak-core/src/main/java/org/apache/j...
Date Tue, 11 Dec 2012 11:16:39 GMT
hi michael

i would really appreciate if you would not comment out test-cases
that i deliberately added, just because a half-way fix of
yours makes them fail.

so, -1 for the changes made in particular the following:

> @@ -332,8 +334,8 @@ public class OakAuthorizablePropertyTest
>       @Test
>       public void testGetPropertyNamesByInvalidRelPath() throws Exception {
>           List<String>  invalidPaths = new ArrayList<String>();
> -        invalidPaths.add("../");
> -        invalidPaths.add("../../");
> +//        invalidPaths.add("../");     // FIXME: these paths are valid on JR2
> +//        invalidPaths.add("../../");
>           invalidPaths.add("../testing");
>           invalidPaths.add("/testing");
>           invalidPaths.add(null);

and:

> Modified: jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/user/AuthorizablePropertyTest.java
> URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/user/AuthorizablePropertyTest.java?rev=1418316&r1=1418315&r2=1418316&view=diff
> ==============================================================================
> --- jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/user/AuthorizablePropertyTest.java
(original)
> +++ jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/user/AuthorizablePropertyTest.java
Fri Dec  7 14:03:31 2012
> @@ -315,8 +315,8 @@ public class AuthorizablePropertyTest ex
>       @Test
>       public void testGetPropertyNamesByInvalidRelPath() throws NotExecutableException,
RepositoryException {
>           List<String>  invalidPaths = new ArrayList<String>();
> -        invalidPaths.add("../");
> -        invalidPaths.add("../../");
> +//        invalidPaths.add("../");  // FIXME: these paths are valid on JR2
> +//        invalidPaths.add("../../");
>           invalidPaths.add("../testing");
>           invalidPaths.add("/testing");
>           invalidPaths.add(null);

consider this to be a veto. please revert the modifications.

kind regards
angela


Mime
View raw message