Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Received-SPF: pass (nike.apache.org: domain of mueller@adobe.com designates
 64.18.1.78 as permitted sender)
From: Thomas Mueller <mueller@adobe.com>
To: "oak-dev@jackrabbit.apache.org" <oak-dev@jackrabbit.apache.org>
Date: Wed, 21 Nov 2012 10:13:38 +0000
Subject: Re: svn commit: r1411900 - in /jackrabbit/oak/trunk/oak-jcr:
 pom.xml src/main/java/org/apache/jackrabbit/oak/jcr/NodeDelegate.java
 src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
Thread-Topic: svn commit: r1411900 - in /jackrabbit/oak/trunk/oak-jcr:
 pom.xml src/main/java/org/apache/jackrabbit/oak/jcr/NodeDelegate.java
 src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
Thread-Index: Ac3H0OFdAMWeWNhjRUiGqbfWvihUDA==
Message-ID: <CCD265C5.377D3%mueller@adobe.com>
In-Reply-To: <50AC90E2.1010704@adobe.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.2.4.120824
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Hi,

For the query engine, I will need a "validate and normalize path" function
that verifies a path is syntactically correct, and simplifies it if
possible, for example:

/a/./b =3D> /a/b
/a/../b =3D> /b

a/.. =3D> .
./a =3D> a
. =3D>=20
a/. =3D> a
/.. =3D> invalid
.. =3D> ..
/./. =3D> /

This will not solve the case where a relative path starts with ".."
(possibly multiple levels). I'm wondering if that would be the only
remaining case (a normalize path would never contain "current path", plus
"parent" would always be at the beginning).

Regards,
Thomas


On 11/21/12 9:29 AM, "Angela Schreiber" <anchela@adobe.com> wrote:

>hi michael
>
>> +        TreeLocation loc =3D getLocation();
>> +        for (String element : PathUtils.elements(relPath)) {
>> +            if (PathUtils.denotesParent(element)) {
>> +                loc =3D loc.getParent();
>> +            } else if (!PathUtils.denotesCurrent(element)) {
>> +                loc =3D loc.getChild(element);
>> +            }  // else . ->  skip to next element
>> +        }
>> +        return loc;
>
>this is exactly the reason why i was asking for having that
>included in TreeLocation and Tree... we keep adding the exact
>same code everywhere and i am quite sure that you didn't
>cover all usages of relativePath defined by JCR API by this
>fix.
>
>this really looks troublesome and hacky to me.
>
>kind regards
>angela