Return-Path: X-Original-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6E399D182 for ; Thu, 15 Nov 2012 17:55:44 +0000 (UTC) Received: (qmail 80472 invoked by uid 500); 15 Nov 2012 17:55:44 -0000 Delivered-To: apmail-jackrabbit-oak-dev-archive@jackrabbit.apache.org Received: (qmail 80435 invoked by uid 500); 15 Nov 2012 17:55:44 -0000 Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-dev@jackrabbit.apache.org Received: (qmail 80426 invoked by uid 99); 15 Nov 2012 17:55:44 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Nov 2012 17:55:44 +0000 X-ASF-Spam-Status: No, hits=-1.6 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [64.18.1.183] (HELO exprod6og102.obsmtp.com) (64.18.1.183) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Nov 2012 17:55:36 +0000 Received: from outbound-smtp-2.corp.adobe.com ([193.104.215.16]) by exprod6ob102.postini.com ([64.18.5.12]) with SMTP ID DSNKUKUsggBABOjZFIjtMo2xW/5M654gK5lg@postini.com; Thu, 15 Nov 2012 09:55:16 PST Received: from inner-relay-4.eur.adobe.com (inner-relay-4b [10.128.4.237]) by outbound-smtp-2.corp.adobe.com (8.12.10/8.12.10) with ESMTP id qAFHtEHP014049 for ; Thu, 15 Nov 2012 09:55:14 -0800 (PST) Received: from nacas03.corp.adobe.com (nacas03.corp.adobe.com [10.8.189.121]) by inner-relay-4.eur.adobe.com (8.12.10/8.12.9) with ESMTP id qAFHtBXM017066 for ; Thu, 15 Nov 2012 09:55:13 -0800 (PST) Received: from eurhub01.eur.adobe.com (10.128.4.30) by nacas03.corp.adobe.com (10.8.189.121) with Microsoft SMTP Server (TLS) id 8.3.279.1; Thu, 15 Nov 2012 09:55:12 -0800 Received: from susi.local (10.136.140.86) by eurhub01.eur.adobe.com (10.128.4.111) with Microsoft SMTP Server id 8.3.279.1; Thu, 15 Nov 2012 17:55:09 +0000 Message-ID: <50A52C7D.1040009@apache.org> Date: Thu, 15 Nov 2012 17:55:09 +0000 From: =?ISO-8859-1?Q?Michael_D=FCrig?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: "oak-dev@jackrabbit.apache.org" Subject: MemoryNodeBuilder cleanup Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Hi, As mentioned on OAK-447, OAK-448 the introduction of the reset method in NodeBuilder lead to the breakdown of some of the class invariants that held earlier. See also the FIXME tags in MemoryNodeBuilder. In addition the code should be simplified where possible. Currently it is very hard to track what's going on just by reading the code, Javadoc and test cases. I started an initial (ongoing) effort in my private branch: https://github.com/mduerig/jackrabbit-oak/commits/nodebuilder-cleanup So we can work on this without affecting the trunk. Michael