jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Mueller <muel...@adobe.com>
Subject Re: svn commit: r1409134 - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/old/ oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/ oak-core/src/main/java/org/apache/jackrabbit/oak/spi/query/ oak-core/sr...
Date Wed, 14 Nov 2012 11:15:07 GMT
Hi,

Yes I came to the same conclusion. However I would prefer it Cursor stays
an interface, because it's an API. I could add an abstract class somewhere
else (in the Cursors class): an AbstractCursor class where remove() throws
an exception. Would that be OK as well?

Regards,
Thomas



On 11/14/12 11:43 AM, "Michael Dürig" <mduerig@apache.org> wrote:

>
>
>On 14.11.12 10:04, thomasm@apache.org wrote:
>> Author: thomasm
>> Date: Wed Nov 14 10:04:55 2012
>> New Revision: 1409134
>>
>> URL:http://svn.apache.org/viewvc?rev=1409134&view=rev
>> Log:
>> OAK-423 Query: org.apache.jackrabbit.oak.spi.query.Cursor.currentRow
>>called too late - refactor the Cursor interface to better match the
>>Iterator interface
>
>Couldn't Cursor extends Iterator<IndexRow> and make it an abstract class
>providing an implementation for remove() which just throws? After all a
>cursor really is an iterator now.
>
>Michael


Mime
View raw message