jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Mueller <muel...@adobe.com>
Subject Re: [MongoMK] BlobStore garbage collection
Date Fri, 02 Nov 2012 14:50:36 GMT

I would definitely at least *try* to implement a MongoDB BlobStore based
on the AbstractBlobStore. It should be quite simple (one class). Then, it
would be interesting to know which implementation is faster: the GridFS
one or an implementation based on AbstractBlobStore :-) Specially if the
difference is big. If GridFS is faster, maybe we could learn something
from them.

It looks like GridFS uses md5 hashes, that sounds a bit risky to me,
specially if anonymous users can create binaries. An attacker could upload
two files with the same md5 hash, which would at least "confuse" Oak and
maybe GridFS, or maybe worse. I mean, using md5 for your own files is
fine, but it seems problematic for Oak, because it would somewhat limit
the use cases.


On 11/2/12 10:30 AM, "Mete Atamel" <matamel@adobe.com> wrote:

>One of the things I need to implement for MongoMK is BlobStore garbage
>collection. I see that there's an initial implementation for garbage
>collection in AbstractBlobStore in oak-mk and I also see this bug [0] to
>improve that initial implementation.
>MongoMK uses a GridFS based BlobStore, separate from AbstractBlobStore in
>oak-mk. I could potentially come up with my own GC, based on that GridFS
>implementation, or I could try a new AbstractBlobStore implementation for
>MongoMK (not GridFS based). With the second approach, I potentially get
>current and future garbage collection improvements for free.
>Not sure which path to follow yet but I wanted to see what others thought
>before starting to work on it.
>[0] https://issues.apache.org/jira/browse/OAK-377

View raw message