From oak-dev-return-2777-apmail-jackrabbit-oak-dev-archive=jackrabbit.apache.org@jackrabbit.apache.org Fri Oct 19 07:56:22 2012 Return-Path: X-Original-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E0788D660 for ; Fri, 19 Oct 2012 07:56:21 +0000 (UTC) Received: (qmail 34898 invoked by uid 500); 19 Oct 2012 07:56:21 -0000 Delivered-To: apmail-jackrabbit-oak-dev-archive@jackrabbit.apache.org Received: (qmail 34705 invoked by uid 500); 19 Oct 2012 07:56:16 -0000 Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-dev@jackrabbit.apache.org Received: (qmail 34683 invoked by uid 99); 19 Oct 2012 07:56:16 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Oct 2012 07:56:16 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of anchela@adobe.com designates 64.18.1.183 as permitted sender) Received: from [64.18.1.183] (HELO exprod6og102.obsmtp.com) (64.18.1.183) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Oct 2012 07:56:06 +0000 Received: from outbound-smtp-1.corp.adobe.com ([192.150.11.134]) by exprod6ob102.postini.com ([64.18.5.12]) with SMTP ID DSNKUIEHgif4lWi+5Tw0w7GWFPPG6+L3RKO2@postini.com; Fri, 19 Oct 2012 00:55:46 PDT Received: from inner-relay-1.corp.adobe.com ([153.32.1.51]) by outbound-smtp-1.corp.adobe.com (8.12.10/8.12.10) with ESMTP id q9J7r31v029146 for ; Fri, 19 Oct 2012 00:53:04 -0700 (PDT) Received: from nahub01.corp.adobe.com (nahub01.corp.adobe.com [10.8.189.97]) by inner-relay-1.corp.adobe.com (8.12.10/8.12.10) with ESMTP id q9J7tZNg021816 for ; Fri, 19 Oct 2012 00:55:45 -0700 (PDT) Received: from eurhub01.eur.adobe.com (10.128.4.30) by nahub01.corp.adobe.com (10.8.189.97) with Microsoft SMTP Server (TLS) id 8.3.279.1; Fri, 19 Oct 2012 00:55:39 -0700 Received: from angela.corp.adobe.com (10.132.1.18) by eurhub01.eur.adobe.com (10.128.4.111) with Microsoft SMTP Server id 8.3.279.1; Fri, 19 Oct 2012 08:54:20 +0100 Message-ID: <5081072C.2050805@adobe.com> Date: Fri, 19 Oct 2012 09:54:20 +0200 From: Angela Schreiber User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11 MIME-Version: 1.0 To: Subject: ContentSession#createBlob ? Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org hi all recent the ContentSession interface got a new method Blob createBlob(InputStream inputStream) throws IOException; this there is no TODO comment associated with it i assume that is intended to stay... however, it feels a bit odd to me having that method on the content session interface and i don't see how and why a regular API consumer of the ContentSession would need/use this. currently the only usage of the method is in a private method on ValueFactoryImpl, which for that very purpose needs to have the content session passed to the constructor but doesn't otherwise need access to the content session at all... imo that should be reviewed again. kind regards angela