Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Received-SPF: pass (nike.apache.org: domain of mueller@adobe.com designates
 64.18.1.35 as permitted sender)
From: Thomas Mueller <mueller@adobe.com>
To: "oak-dev@jackrabbit.apache.org" <oak-dev@jackrabbit.apache.org>
Date: Fri, 14 Sep 2012 08:47:58 +0100
Subject: Re: ContentSession.getCurrentRoot() is slow
Thread-Topic: ContentSession.getCurrentRoot() is slow
Thread-Index: Ac2STUb4YdJ+h5aYTVSFYpLBgJlFDg==
Message-ID: <CC78AB8C.33BC3%mueller@adobe.com>
In-Reply-To: <CC7889A1.33B74%mueller@adobe.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.2.3.120616
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Hi,

What about renaming ContentSession.getCurrentRoot() to getHeadRoot() or
getCurrentHeadRoot()?

About workspaces - I know we said we don't support workspaces currently,
but there still is ContentSession.getWorkspaceName(). Could we remove this
method for now? The problem is that it's not clear whether
getCurrentRoot(), and the Root class, is for the / a workspace or for the
complete repository.


About the class Root: is the data returned by this class filtered for the
ContentSessions access rights? I can't find that info in the Javadocs. If
it is, maybe we could (later on) combine Root and ContentSession. But for
now I guess it's enough to add a comment in the Javadoc.

Regards,
Thomas

On 9/14/12 7:32 AM, "Thomas Mueller" <mueller@adobe.com> wrote:

>Hi,
>
>>It would be better if the query engine used the same tree snapshot as
>>the rest of the session. There shouldn't be any need to call
>>getCurrentRoot().
>
>This is actually what I expected that ContentSession.getCurrentRoot()
>would provide me: I expected getCurrentRoot() would always return the same
>root until the session has committed or refreshed. It wasn't obvious to me
>neither from the method name nor from the javadocs that there is
>(potentially) a new current root every time the method is called. Not a
>problem, I can change the javadocs and add that info.
>
>But now I see that the ContentSession doesn't in fact know the current
>revision and doesn't provide snapshot isolation, how do I use the same
>tree snapshot as the rest of the session? Is it the oak-jcr
>SessionDelegate.root field? I guess I will have to change the oak-core
>query API then, and add the Root as a parameter to the method
>SessionQueryEngine.executeQuery?
>
>Regards,
>Thomas
>