Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Received-SPF: pass (athena.apache.org: domain of jukka.zitting@gmail.com
 designates 209.85.220.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CC7889A1.33B74%mueller@adobe.com>
References: 
 <CAOFYJNYapS=x0t5TyXaN6Ba8WXWVLyndcq=uJ3HwUN4eNj--PQ@mail.gmail.com>
 <CC7889A1.33B74%mueller@adobe.com>
From: Jukka Zitting <jukka.zitting@gmail.com>
Date: Fri, 14 Sep 2012 09:55:41 +0200
Message-ID: 
 <CAOFYJNbF=GwQDtVbKan7_mkfSZzj5AoEGKnJtJ1+QUpceeUS=A@mail.gmail.com>
Subject: Re: ContentSession.getCurrentRoot() is slow
To: oak-dev@jackrabbit.apache.org
Content-Type: text/plain; charset=ISO-8859-1

Hi,

On Fri, Sep 14, 2012 at 7:32 AM, Thomas Mueller <mueller@adobe.com> wrote:
> This is actually what I expected that ContentSession.getCurrentRoot()
> would provide me: I expected getCurrentRoot() would always return the same
> root until the session has committed or refreshed. It wasn't obvious to me
> neither from the method name nor from the javadocs that there is
> (potentially) a new current root every time the method is called. Not a
> problem, I can change the javadocs and add that info.

Yep, the javadocs should probably be improved for this. The rationale
for not always returning the same root is to allow oak-jcr to
implement directly persisted operations like workspace copies without
having to acquire a separate ContentSession (and thus re-authenticate
itself).

> But now I see that the ContentSession doesn't in fact know the current
> revision and doesn't provide snapshot isolation, how do I use the same
> tree snapshot as the rest of the session? Is it the oak-jcr
> SessionDelegate.root field? I guess I will have to change the oak-core
> query API then, and add the Root as a parameter to the method
> SessionQueryEngine.executeQuery?

A better alternative might be to move the getQueryEngine() method from
ContentSession to Root. That way the returned QueryEngine instance can
already contain an internal reference to the relevant Root.

BR,

Jukka Zitting