Return-Path: X-Original-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 306DBDCD5 for ; Thu, 6 Sep 2012 12:29:32 +0000 (UTC) Received: (qmail 15523 invoked by uid 500); 6 Sep 2012 12:29:32 -0000 Delivered-To: apmail-jackrabbit-oak-dev-archive@jackrabbit.apache.org Received: (qmail 15331 invoked by uid 500); 6 Sep 2012 12:29:26 -0000 Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-dev@jackrabbit.apache.org Received: (qmail 15277 invoked by uid 99); 6 Sep 2012 12:29:25 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Sep 2012 12:29:25 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jukka.zitting@gmail.com designates 209.85.212.42 as permitted sender) Received: from [209.85.212.42] (HELO mail-vb0-f42.google.com) (209.85.212.42) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Sep 2012 12:29:19 +0000 Received: by vbbfs19 with SMTP id fs19so2788247vbb.1 for ; Thu, 06 Sep 2012 05:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=IP8V1ZS/GDAgs4cMiG9p/KsGQ2pOablUZHh2xBsTPxo=; b=i4itdPuZsbrOegUXrGlQyQdRZVMrpiUZyufZXSgjR/fVTLE5EdgvrGVVOGLDwgcZtu +e/LppyttY+O2L+JLz8VicrgPLkOf2HzTkuwOhbu01y8Ynge7KXX66uAYyQVXcw0qjF3 76xcwscsHeTj6vb5TdOeIHpasMgrDUdjRgIzYcUQaZghwIshsAotxAXZgZuUdSdq9hmu Wbqzyf6/x+pauo220uE49R49cEyGwsk+HlXpWtC1rZnpz+nhjEhRyeG5U/SqD5h4L5ei f/yYJ87PDlzfGScS1XddTf1oL7u+APELHQRb1OLd4JsOusb0tLXlLFodpQc5mzdsqlY7 k+Zg== Received: by 10.52.67.144 with SMTP id n16mr1535676vdt.13.1346934538470; Thu, 06 Sep 2012 05:28:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.58.91.194 with HTTP; Thu, 6 Sep 2012 05:28:38 -0700 (PDT) In-Reply-To: <20120906122016.31AFC2388900@eris.apache.org> References: <20120906122016.31AFC2388900@eris.apache.org> From: Jukka Zitting Date: Thu, 6 Sep 2012 14:28:38 +0200 Message-ID: Subject: Re: svn commit: r1381571 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/ContentRepository.java To: oak-dev@jackrabbit.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org Hi, On Thu, Sep 6, 2012 at 2:20 PM, wrote: > I think we need to be more strict here. Otherwise we should remove the close() > method from ContentSession. Hmm, good point. I'd be in favor of removing the ContentSession.close() method if we can. There shouldn't be any resources associated with a session that normal garbage collection couldn't take care of. BR, Jukka Zitting