Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Received-SPF: pass (nike.apache.org: domain of mreutegg@adobe.com designates
 64.18.1.31 as permitted sender)
From: Marcel Reutegger <mreutegg@adobe.com>
To: "oak-dev@jackrabbit.apache.org" <oak-dev@jackrabbit.apache.org>
Date: Wed, 12 Sep 2012 10:29:46 +0100
Subject: ChildNodeEntry
Thread-Topic: ChildNodeEntry
Thread-Index: Ac2QyJCThYsUKDVcQ3Sjkr/lFEOdPA==
Message-ID: 
 <9C0FC4C8E9C29945B01766FC7F9D389816FE0B21F7@eurmbx01.eur.adobe.com>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Hi,

I was wondering why we have the interface ChildNodeEntry?
To me it looks like its usages can be replaced with other methods
on NodeState. e.g. the following code in JsopDiff.toJson(NodeState, JsopBui=
lder):

        for (ChildNodeEntry child : nodeState.getChildNodeEntries()) {
            jsop.key(child.getName());
            toJson(child.getNodeState(), jsop);
        }

can simply be replaced with:

        for (String childName : nodeState.getChildNodeNames()) {
            jsop.key(childName);
            toJson(nodeState.getChildNode(childName), jsop);
        }

regards
 marcel