From oak-dev-return-2506-apmail-jackrabbit-oak-dev-archive=jackrabbit.apache.org@jackrabbit.apache.org Thu Sep 6 13:43:22 2012 Return-Path: X-Original-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 378D2DD88 for ; Thu, 6 Sep 2012 13:43:22 +0000 (UTC) Received: (qmail 42787 invoked by uid 500); 6 Sep 2012 13:43:22 -0000 Delivered-To: apmail-jackrabbit-oak-dev-archive@jackrabbit.apache.org Received: (qmail 42763 invoked by uid 500); 6 Sep 2012 13:43:22 -0000 Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-dev@jackrabbit.apache.org Received: (qmail 42755 invoked by uid 99); 6 Sep 2012 13:43:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Sep 2012 13:43:22 +0000 X-ASF-Spam-Status: No, hits=-1.6 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [64.18.1.183] (HELO exprod6og102.obsmtp.com) (64.18.1.183) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Sep 2012 13:43:12 +0000 Received: from outbound-smtp-1.corp.adobe.com ([192.150.11.134]) by exprod6ob102.postini.com ([64.18.5.12]) with SMTP ID DSNKUEioWjOZKVq2JyHAyqUZ/EKJ8qJULSyn@postini.com; Thu, 06 Sep 2012 06:42:51 PDT Received: from inner-relay-4.eur.adobe.com (inner-relay-4.adobe.com [193.104.215.14]) by outbound-smtp-1.corp.adobe.com (8.12.10/8.12.10) with ESMTP id q86DeGk0019449 for ; Thu, 6 Sep 2012 06:40:17 -0700 (PDT) Received: from nacas03.corp.adobe.com (nacas03.corp.adobe.com [10.8.189.121]) by inner-relay-4.eur.adobe.com (8.12.10/8.12.9) with ESMTP id q86DglYs024053 for ; Thu, 6 Sep 2012 06:42:48 -0700 (PDT) Received: from eurhub01.eur.adobe.com (10.128.4.30) by nacas03.corp.adobe.com (10.8.189.121) with Microsoft SMTP Server (TLS) id 8.3.264.0; Thu, 6 Sep 2012 06:42:47 -0700 Received: from susi.local (10.136.143.18) by eurhub01.eur.adobe.com (10.128.4.111) with Microsoft SMTP Server id 8.3.264.0; Thu, 6 Sep 2012 14:42:46 +0100 Message-ID: <5048A856.9050600@apache.org> Date: Thu, 6 Sep 2012 14:42:46 +0100 From: =?ISO-8859-1?Q?Michael_D=FCrig?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:15.0) Gecko/20120824 Thunderbird/15.0 MIME-Version: 1.0 To: Subject: Re: Root.getTree(String) References: <9C0FC4C8E9C29945B01766FC7F9D389816FE0B1F2E@eurmbx01.eur.adobe.com> <50489C11.8040406@apache.org> <50489CC9.9000306@apache.org> <9C0FC4C8E9C29945B01766FC7F9D389816FE0B1F35@eurmbx01.eur.adobe.com> In-Reply-To: <9C0FC4C8E9C29945B01766FC7F9D389816FE0B1F35@eurmbx01.eur.adobe.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 8bit On 6.9.12 14:12, Marcel Reutegger wrote: > OK, see OAK-291. > > what about Tree? > > e.g. I'm a bit confused by the following method: > > /** > * @return path of this {@code Tree} instance relative to its {@link Root}. > */ > @Nonnull > String getPath(); Right, that's confusing. Its a leftover from an earlier version where the path was indeed relative to the workspace (which lived inside the Root). > > this sounds like the returned path is relative. how about: > > /** > * @return the absolute path of this {@code Tree} instance from its {@link Root}. > */ > @Nonnull > String getPath(); Much better! +1. Michael > > regards > marcel > >> -----Original Message----- >> From: Michael Dürig [mailto:mduerig@apache.org] >> Sent: Donnerstag, 6. September 2012 14:53 >> To: oak-dev@jackrabbit.apache.org >> Subject: Re: Root.getTree(String) >> >> >> >> On 6.9.12 13:50, Michael Dürig wrote: >>> >>> Hi,¨ >>> >>> On 6.9.12 13:29, Marcel Reutegger wrote: >>>> the method Root.getTree(String) does not specify any restrictions for >>>> the passed path string (relative, absolute?). >>> >>> This has come up before. See >>> https://issues.apache.org/jira/browse/OAK-221. The Oak core API is only >>> concerned with absolute paths. Maybe we should make this more explicit >>> in the Javadoc. >> >> Ermm, that was the case before TreeLocation was introduced. The latter >> actually can handle relative paths. So I think its best to document all >> paths used in Root as absolute. >> >> Michael >> >>> >>> Michael