jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marcel Reutegger <mreut...@adobe.com>
Subject RE: Root.getTree(String)
Date Thu, 06 Sep 2012 13:12:56 GMT
OK, see OAK-291.

what about Tree?

e.g. I'm a bit confused by the following method:

    /**
     * @return  path of this {@code Tree} instance relative to its {@link Root}.
     */
    @Nonnull
    String getPath();

this sounds like the returned path is relative. how about:

    /**
     * @return the absolute path of this {@code Tree} instance from its {@link Root}.
     */
    @Nonnull
    String getPath();

regards
 marcel

> -----Original Message-----
> From: Michael Dürig [mailto:mduerig@apache.org]
> Sent: Donnerstag, 6. September 2012 14:53
> To: oak-dev@jackrabbit.apache.org
> Subject: Re: Root.getTree(String)
> 
> 
> 
> On 6.9.12 13:50, Michael Dürig wrote:
> >
> > Hi,¨
> >
> > On 6.9.12 13:29, Marcel Reutegger wrote:
> >> the method Root.getTree(String) does not specify any restrictions for
> >> the passed path string (relative, absolute?).
> >
> > This has come up before. See
> > https://issues.apache.org/jira/browse/OAK-221. The Oak core API is only
> > concerned with absolute paths. Maybe we should make this more explicit
> > in the Javadoc.
> 
> Ermm, that was the case before TreeLocation was introduced. The latter
> actually can handle relative paths. So I think its best to document all
> paths used in Root as absolute.
> 
> Michael
> 
> >
> > Michael

Mime
View raw message