Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Received-SPF: pass (nike.apache.org: domain of jukka.zitting@gmail.com
 designates 209.85.220.170 as permitted sender)
MIME-Version: 1.0
Date: Tue, 14 Aug 2012 23:10:49 +0200
Message-ID: 
 <CAOFYJNYEPAFFKk3LN9hW2nx3OfhfGh+Jhi279pf-7SByEB7Z9g@mail.gmail.com>
Subject: Re: svn commit: r1368425 - in /jackrabbit/oak/trunk:
 oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/
 oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/observation/
 oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/osgi/
 oak-jcr/src/main/java
From: Jukka Zitting <jukka.zitting@gmail.com>
To: "oak-dev@jackrabbit.apache.org" <oak-dev@jackrabbit.apache.org>
Content-Type: multipart/alternative; boundary=047d7bea44baa5a48504c7403e3a

--047d7bea44baa5a48504c7403e3a
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi,

On Tuesday, August 14, 2012, Michael D=FCrig wrote:
>
> This change will prevent the repository from shutting down until all
> observation events from a running diff are delivered. Depending on the
> number of changes in the tree this could delay shutdown for quite some ti=
me.


Hmm, if that's the case, then it's a bug. Is there a test case?

In general the repository shutdown should IMO *never* block for any
background tasks. A "kill -9" on a JVM process should IMHO be considered a
valid way to shutdown a repository running inside the JVM, so there's
nothing that the repository should expect a background task to finish in
time for shutdown.

BR,

Jukka Zitting

--047d7bea44baa5a48504c7403e3a--