Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Date: Fri, 17 Aug 2012 03:01:38 +1100 (NCT)
From: =?utf-8?Q?Michael_D=C3=BCrig_=28JIRA=29?= <jira@apache.org>
To: oak-dev@jackrabbit.apache.org
Message-ID: <481283334.19355.1345132898919.JavaMail.jiratomcat@arcas>
In-Reply-To: <363403377.9293.1343982063793.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (OAK-230) Review and fix inconsistent usage of
 oak-path in oak-jcr
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/OAK-230?page=3Dcom.atlassian.ji=
ra.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1343605=
7#comment-13436057 ]=20

Michael D=C3=BCrig commented on OAK-230:
-----------------------------------

Added some Javadoc for clarification in revision 1373892.

The initial understanding was, that all *Delegate classes use oak paths for=
 their operations. The exceptions being methods for converting from JCR pat=
hs to oak paths. In these cases the parameter names indicate this (e.g. jcr=
Path instead of just path).
               =20
> Review and fix inconsistent usage of oak-path in oak-jcr
> --------------------------------------------------------
>
>                 Key: OAK-230
>                 URL: https://issues.apache.org/jira/browse/OAK-230
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>            Reporter: angela
>
> as stated in the main issues there seems to be some inconsistency when it
> comes to passing a path to the oak api in oak-jcr. this should be
> reviewed and fixed throughout the project and the javadoc and method sign=
ature
> of the affected methods (in particular in *Delegate) should be adjusted
> such that it's unambiguous with path parameter are expected to be passed
> to the method calls which paths are being returned.
> for example:
> - SessionDelegate#getNode
> - SessionDelegate#getNodeByIdentifier

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira