Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Date: Tue, 28 Aug 2012 22:30:08 +1100 (NCT)
From: =?utf-8?Q?Michael_D=C3=BCrig_=28JIRA=29?= <jira@apache.org>
To: oak-dev@jackrabbit.apache.org
Message-ID: <1011157150.5653.1346153408117.JavaMail.jiratomcat@arcas>
In-Reply-To: <133604742.5481.1346145787793.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (OAK-281) Move ChangeProcessor to oak-core
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/OAK-281?page=3Dcom.atlassian.ji=
ra.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1344307=
7#comment-13443077 ]=20

Michael D=C3=BCrig commented on OAK-281:
-----------------------------------

Generally +1. However, wouldn't it be better to include {{startDiff()}} end=
 {{endDiff()}} methods directly in {{NodeStateDiff}} instead of introducing=
 {{NotificationNodeStateDiff}}? That way, {{RootImpl.getChangeExtractor()}}=
 could directly call those methods. I think such methods could be helpful f=
or the other use cases of {{NodeStateDiff}} as well.=20
               =20
> Move ChangeProcessor to oak-core
> --------------------------------
>
>                 Key: OAK-281
>                 URL: https://issues.apache.org/jira/browse/OAK-281
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, jcr
>            Reporter: Alex Parvulescu
>         Attachments: OAK-281.patch
>
>
> I'd like to move the ChangeProcessor to oak-core so other components (lik=
e the IndexManager) can leverage the change observation mechanism

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira