jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-245) Add import for org.h2 in oak-mk bundle
Date Wed, 15 Aug 2012 14:32:38 GMT

    [ https://issues.apache.org/jira/browse/OAK-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435156#comment-13435156
] 

Thomas Mueller commented on OAK-245:
------------------------------------

>> Class.forName("org.h2.Driver")
> This would constitute a bug in itself.

I don't consider this "a bug". Let's say it doesn't work well with OSGi.

But I believe both Class.forName and org.h2.Driver.load() are not required here, as anyway
the H2 connection pool is used. I would simply remove the line.
                
> Add import for org.h2 in oak-mk bundle
> --------------------------------------
>
>                 Key: OAK-245
>                 URL: https://issues.apache.org/jira/browse/OAK-245
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: mk
>            Reporter: Chetan Mehrotra
>              Labels: osgi
>         Attachments: import-h2.patch, OAK-245-load-driver.patch
>
>
> The oak-mk bundle depends on H2 database. It internally uses Class.forName('org.h2.Driver")
to load the H2 driver. Due to usage of Class.forName Bnd is not able to add org.h2 package
to Import-Package list. So it should have an explicit entry in the maven-bundle-plugin config
as shown below
> {code:xml}
> <Import-Package>
>   org.h2;resolution:=optional,
>   *
> </Import-Package>
> {code}
> Without this MicroKernalService loading would fail with a CNFE

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message