jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-212) Move status of property to PropertyState
Date Fri, 03 Aug 2012 10:45:02 GMT

    [ https://issues.apache.org/jira/browse/OAK-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427982#comment-13427982
] 

Jukka Zitting commented on OAK-212:
-----------------------------------

I think we could even come up with some way to track the status of such properties. However,
just like we don't have a {{setValue()}} method on {{PropertyState}} (the instances are supposed
to be immutable), the status of a property shouldn't be available from the {{PropertyState}}
instance itself.

Instead, for handling cases like {{session.getProperty("/path/to/property")}} when faced with
such access controls we might need methods like {{Root.getProperty(String path)}}, {{Root.setProperty(String
path, ...)}} and {{Root.getPropertyStatus(String path)}}.

Normal cases where a property is accessed with {{node.getProperty("property")}} should ideally
still use the already existing property access methods on {{Tree}} to avoid the extra path
lookups on each access.
                
> Move status of property to PropertyState
> ----------------------------------------
>
>                 Key: OAK-212
>                 URL: https://issues.apache.org/jira/browse/OAK-212
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: angela
>
> Currently the status of a property is retrieved from the parent tree object.
> With access control being enforced a property may be accessible even if the
> parent tree isn't.
> IMO the status should therefore be retrieved from the PropertyState instead
> of calling Tree#getPropertyStatus.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message