jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Commented] (OAK-230) Review and fix inconsistent usage of oak-path in oak-jcr
Date Thu, 16 Aug 2012 16:01:38 GMT

    [ https://issues.apache.org/jira/browse/OAK-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436057#comment-13436057
] 

Michael Dürig commented on OAK-230:
-----------------------------------

Added some Javadoc for clarification in revision 1373892.

The initial understanding was, that all *Delegate classes use oak paths for their operations.
The exceptions being methods for converting from JCR paths to oak paths. In these cases the
parameter names indicate this (e.g. jcrPath instead of just path).
                
> Review and fix inconsistent usage of oak-path in oak-jcr
> --------------------------------------------------------
>
>                 Key: OAK-230
>                 URL: https://issues.apache.org/jira/browse/OAK-230
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>            Reporter: angela
>
> as stated in the main issues there seems to be some inconsistency when it
> comes to passing a path to the oak api in oak-jcr. this should be
> reviewed and fixed throughout the project and the javadoc and method signature
> of the affected methods (in particular in *Delegate) should be adjusted
> such that it's unambiguous with path parameter are expected to be passed
> to the method calls which paths are being returned.
> for example:
> - SessionDelegate#getNode
> - SessionDelegate#getNodeByIdentifier

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message