jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-232) Hardcoded "childOrder" in NodeDelegate
Date Fri, 03 Aug 2012 13:09:02 GMT

    [ https://issues.apache.org/jira/browse/OAK-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428062#comment-13428062
] 

Jukka Zitting commented on OAK-232:
-----------------------------------

I agree about the hardcoding, but IMHO it would have been better to make the commit as a part
of OAK-169 so that all changes related to that feature are nicely contained in one issue.
Spreading small commits like this across many issues makes it harder at least for me to follow
the big picture.
                
> Hardcoded "childOrder" in NodeDelegate
> --------------------------------------
>
>                 Key: OAK-232
>                 URL: https://issues.apache.org/jira/browse/OAK-232
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, jcr
>            Reporter: angela
>
> there has been some discussion recently on how to deal with internal (hidden?) content

> such as for example the property reflecting the order of child nodes (see http://markmail.org/message/kzt7csiz2bd5n3ww).
> while working on some initial permission code i found that currently that property name
> is hardcoded in multiple places in NodeDelegate while at the same time the javadoc of
> NodeDelegate#getChildren refers to a different property name.
> until we reach consensus on how to deal with such internal content, if/how to hide it
from
> JCR API consumers and whether or not (and to which extend) that should be a implementation

> detail of oak-core, i would suggest to define at least a constant on PropertyState that
> allows to easily identify and adjust all usages.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message