jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Created] (OAK-241) QueryEngine.executeQuery needs a session parameter
Date Mon, 13 Aug 2012 15:24:38 GMT
Thomas Mueller created OAK-241:

             Summary: QueryEngine.executeQuery needs a session parameter
                 Key: OAK-241
                 URL: https://issues.apache.org/jira/browse/OAK-241
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: core
            Reporter: Thomas Mueller
            Assignee: Thomas Mueller
            Priority: Minor

The method QueryEngine.executeQuery currently needs a ContentSession parameter, even thought
the instance was retrieved from the ContentSession using ContentSession.getQueryEngine().
This is a bit confusing.

To solve this, we could rename the QueryEngine interface to SessionQueryEngine, change QueryEngineImpl
so it no longer implements any interface, add a class SessionQueryEngineImpl that calls the
QueryEngineImpl methods (1:1, except for executeQuery where it adds the session parameter).

An alternative would be to change the existing QueryEngineImpl so a new instance is created
for each session. But I prefer not todo this as conceptually there is only one query engine.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message