jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-288) QueryTests should use the NodeStore apis
Date Fri, 31 Aug 2012 09:48:08 GMT

    [ https://issues.apache.org/jira/browse/OAK-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445804#comment-13445804
] 

Thomas Mueller commented on OAK-288:
------------------------------------

> util class

That looks good to me.

> bypassing the CommitHook and going directly to the mk level 
> while ignoring the oak-core layer is poor separation of concerns.

You already wrote that, and I already wrote I used the MicroKernel API because it is a stable
API, while the oak-core API was not stable when I wrote the tests. Actually the oak-core API
didn't exist yet. Now that the oak-core API is ready, it does make sense to use it.

> the current property index implementation doesn't play nice 
> with existing notification mechanisms (like the CommitHook).

Sorry I don't understand, what do you mean with 'doesn't play nice'?

> the query tests pass if I update them to use the NodeStore, except the 'explain' ones.

Hm, they should work if the same indexes are available... could you post the result you get?


                
> QueryTests should use the NodeStore apis
> ----------------------------------------
>
>                 Key: OAK-288
>                 URL: https://issues.apache.org/jira/browse/OAK-288
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Alex Parvulescu
>         Attachments: OAK-288-jsop-util.patch
>
>
> Currently the existing oak query tests come in form of a "script" file [0] that contains

>  - commit commands which will be executed directly against the mk.
>  - select commands
>  - expected results
> while this was good for fast prototyping we should refactor the tests to use proper unit
tests.
> Arguments for refactoring:
>  - overall java style unit tests, reduce the complexity of running this setup
>  - proper reporting unit test failures
>  - executing the commit commands directly against the mk breaks the {{CommitHook}} mechanism
because the commits will pass unnoticed
>  - proper separation of concerns - oak core should not directly reference the mk, it
should pass through exisiting apis like the {{NodeStore}}
> [0] http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/test/resources/org/apache/jackrabbit/oak/query/sql2.txt?view=markup

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message