Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Received-SPF: pass (nike.apache.org: domain of anchela@adobe.com designates
 64.18.1.187 as permitted sender)
Message-ID: <500E8764.8040109@adobe.com>
Date: Tue, 24 Jul 2012 13:30:44 +0200
From: Angela Schreiber <anchela@adobe.com>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US;
 rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11
MIME-Version: 1.0
To: <oak-dev@jackrabbit.apache.org>
Subject: Comment regarding TreeImpl#remove
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit

hi michael

the implementation of Tree#remove starts with the following line:

         if (!isRoot() && parent.hasChild(name)) {

and it seems to me that testing for the parent containing the
Tree that i am having at hand is superfluous. is that the
leftover of a refactoring or could it really occur that in this
situation parent.hasChild returns false? if the latter was
true, i think this line deserves a little comment explaining
to the poor reader what are the circumstances of that behaviour.
maybe we would even need some log output for that special case.

what do you think?
angela