Return-Path: X-Original-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4E64C9127 for ; Tue, 24 Jul 2012 11:22:37 +0000 (UTC) Received: (qmail 60839 invoked by uid 500); 24 Jul 2012 11:22:37 -0000 Delivered-To: apmail-jackrabbit-oak-dev-archive@jackrabbit.apache.org Received: (qmail 60429 invoked by uid 500); 24 Jul 2012 11:22:36 -0000 Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-dev@jackrabbit.apache.org Received: (qmail 60361 invoked by uid 99); 24 Jul 2012 11:22:34 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jul 2012 11:22:34 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 3E55F1402B8 for ; Tue, 24 Jul 2012 11:22:34 +0000 (UTC) Date: Tue, 24 Jul 2012 11:22:33 +0000 (UTC) From: =?utf-8?Q?Michael_D=C3=BCrig_=28JIRA=29?= To: oak-dev@jackrabbit.apache.org Message-ID: <1891652227.95190.1343128954257.JavaMail.jiratomcat@issues-vm> In-Reply-To: <643119797.58133.1342449995527.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (OAK-189) Swallowed exceptions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OAK-189?page=3Dcom.atlassian.ji= ra.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1342133= 0#comment-13421330 ]=20 Michael D=C3=BCrig commented on OAK-189: ----------------------------------- This is another example for why I think checked exceptions are not worth it= . It forces exceptions to be handled in places where nothing can be done ab= out them. So they are just ignored...=20 =20 > Swallowed exceptions > -------------------- > > Key: OAK-189 > URL: https://issues.apache.org/jira/browse/OAK-189 > Project: Jackrabbit Oak > Issue Type: Bug > Components: jcr > Reporter: Thomas Mueller > > Exceptions should not be silently swallowed. This is currently done in Se= ssionDelegate$SessionNameMapper, methods getOakPrefix(), getOakPrefixFromUR= I(), and getJcrPrefix(). Those methods catch RepositoryException, don't log= by default (only when using debug level), and don't log the exception stac= k trace or throw an exception. > Catching a very wide band of exceptions (RepositoryException) and then si= mply returning null is not an acceptable solution in my view. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp= a For more information on JIRA, see: http://www.atlassian.com/software/jira