jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-189) Swallowed exceptions
Date Wed, 25 Jul 2012 14:32:34 GMT

    [ https://issues.apache.org/jira/browse/OAK-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422310#comment-13422310
] 

Thomas Mueller commented on OAK-189:
------------------------------------

Well, this is not about checked versus uncheck exceptions, but about catching an exception
and then simply "return null", without logging the exception, without re-throwing a different
exception. The exception is silently ignored, and the code behaves in a different way.
                
> Swallowed exceptions
> --------------------
>
>                 Key: OAK-189
>                 URL: https://issues.apache.org/jira/browse/OAK-189
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: jcr
>            Reporter: Thomas Mueller
>
> Exceptions should not be silently swallowed. This is currently done in SessionDelegate$SessionNameMapper,
methods getOakPrefix(), getOakPrefixFromURI(), and getJcrPrefix(). Those methods catch RepositoryException,
don't log by default (only when using debug level), and don't log the exception stack trace
or throw an exception.
> Catching a very wide band of exceptions (RepositoryException) and then simply returning
null is not an acceptable solution in my view.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message