jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-202) Simplify the code when possible
Date Tue, 24 Jul 2012 07:58:34 GMT

    [ https://issues.apache.org/jira/browse/OAK-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421251#comment-13421251
] 

Thomas Mueller commented on OAK-202:
------------------------------------

Based on feedback I got by email seems some people think I committed revision 1364664. It
wasn't me :-)

https://fisheye6.atlassian.com/changelog/jackrabbit?cs=1364664

my changes were:

https://fisheye6.atlassian.com/changelog/jackrabbit?cs=1364616
https://fisheye6.atlassian.com/changelog/jackrabbit?cs=1364573

I wonder whether we could have automatic links to revisions?
                
> Simplify the code when possible
> -------------------------------
>
>                 Key: OAK-202
>                 URL: https://issues.apache.org/jira/browse/OAK-202
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: Thomas Mueller
>            Priority: Minor
>
> Sometimes it's possible to simplify the code, for example: 
> - making methods static when possible, so a reader knows the method doesn't change the
state of an object 
> - the "else" is unnecessary if the "if" block always returns

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message