Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: oak-dev@jackrabbit.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <4FD8478E.8080204@apache.org>
Date: Wed, 13 Jun 2012 08:55:58 +0100
From: =?ISO-8859-1?Q?Michael_D=FCrig?= <mduerig@apache.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: <oak-dev@jackrabbit.apache.org>
Subject: Re: NodeDelegate leakage from NodeImpl
References: <CBFE068B.2D931%mueller@adobe.com>
In-Reply-To: <CBFE068B.2D931%mueller@adobe.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 8bit


On 13.6.12 8:04, Thomas Mueller wrote:
> Hi,
>
>> This defeats the original intent of the
>> separation of NodeImpl and NodeDelegate (OAK-84)
>> users should not be able to gain access to internals by hacking NodeImpl.
>
>
> Hm, is this a security problem? Do we want to protect the data from users
> of the JCR API?

No, its about making it as difficult as possible to mess things up by 
using internals. I.e. its about avoiding the

   ((NodeImpl) node).messWithMe();

pattern.

Michael


>
> Or do we want to protect the data within the Oak implementation (use a
> better abstraction)?
>
>> But precisely this
>> is now possible when a user put his code into the
>> org.apache.jackrabbit.oak.jcr package.
>
> A attacker could always use reflection (setAccessible(true)). If we want
> real protection, we would have to enforce using a SecurityManager. Then we
> could seal the package [1]
>
> [1] http://docs.oracle.com/javase/tutorial/deployment/jar/sealman.html
>
> Regards,
> Thomas
>
>
>
>
>
>
>
> On 6/7/12 1:07 PM, "Michael D�rig"<michid@gmail.com>  wrote:
>
>>
>> Hi,
>>
>> I noticed that since revision 1344662 NodeImpl has an (package private)
>> accessor for NodeDelegate. This defeats the original intent of the
>> separation of NodeImpl and NodeDelegate (OAK-84): users should not be
>> able to gain access to internals by hacking NodeImpl. But precisely this
>> is now possible when a user put his code into the
>> org.apache.jackrabbit.oak.jcr package.
>>
>> Michael
>>
>>
>