From oak-dev-return-1364-apmail-jackrabbit-oak-dev-archive=jackrabbit.apache.org@jackrabbit.apache.org Wed Jun 6 12:35:13 2012 Return-Path: X-Original-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Delivered-To: apmail-jackrabbit-oak-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 57BDCCA0B for ; Wed, 6 Jun 2012 12:35:13 +0000 (UTC) Received: (qmail 56446 invoked by uid 500); 6 Jun 2012 12:35:13 -0000 Delivered-To: apmail-jackrabbit-oak-dev-archive@jackrabbit.apache.org Received: (qmail 56374 invoked by uid 500); 6 Jun 2012 12:35:13 -0000 Mailing-List: contact oak-dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: oak-dev@jackrabbit.apache.org Delivered-To: mailing list oak-dev@jackrabbit.apache.org Received: (qmail 56355 invoked by uid 99); 6 Jun 2012 12:35:13 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jun 2012 12:35:13 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of julian.reschke@gmx.de designates 213.165.64.22 as permitted sender) Received: from [213.165.64.22] (HELO mailout-de.gmx.net) (213.165.64.22) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 06 Jun 2012 12:35:04 +0000 Received: (qmail invoked by alias); 06 Jun 2012 12:34:42 -0000 Received: from mail.greenbytes.de (EHLO [192.168.1.140]) [217.91.35.233] by mail.gmx.net (mp010) with SMTP; 06 Jun 2012 14:34:42 +0200 X-Authenticated: #1915285 X-Provags-ID: V01U2FsdGVkX18AOCxvKYsAmNypPbd77fIXcCvas9RjfX5A7du0PI CwnjtniPkU7/wQ Message-ID: <4FCF4E61.4080405@gmx.de> Date: Wed, 06 Jun 2012 14:34:41 +0200 From: Julian Reschke User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120604 Thunderbird/13.0 MIME-Version: 1.0 To: oak-dev@jackrabbit.apache.org CC: Angela Schreiber Subject: Re: svn commit: r1346781 - /jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/NodeImpl.java References: <20120606084301.64C512388980@eris.apache.org> <4FCF3FAF.7070104@gmx.de> <4FCF485D.1070208@adobe.com> <4FCF4A44.8070704@gmx.de> <4FCF4C9F.5050004@adobe.com> In-Reply-To: <4FCF4C9F.5050004@adobe.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Virus-Checked: Checked by ClamAV on apache.org On 2012-06-06 14:27, Angela Schreiber wrote: > hi julian > >>> NodeTypeImpl#isNodeType which was comparing the jcr-name >>> exposed in getName() with the string passed to the call. >>> the latter can of course be an expanded name too such as >>> the one i used with the constant :-) >> >> Yes, it's all a mess right now :-). > > indeed. i would suggest that we stop using hardcoded > strings and use the constants defined in the JCR API instead. Absolutely. We just need to be careful with layering; as far as I understand the expanded names will not work for Oak-Core APIs. Best regards, Julian