jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Angela Schreiber <anch...@adobe.com>
Subject Re: NodeDelegate leakage from NodeImpl
Date Thu, 07 Jun 2012 13:55:03 GMT
On 6/7/12 1:55 PM, Julian Reschke wrote:
> On 2012-06-07 13:07, Michael Dürig wrote:
>> Hi,
>> I noticed that since revision 1344662 NodeImpl has an (package private)
>> accessor for NodeDelegate. This defeats the original intent of the
>> separation of NodeImpl and NodeDelegate (OAK-84): users should not be
>> able to gain access to internals by hacking NodeImpl. But precisely this
>> is now possible when a user put his code into the
>> org.apache.jackrabbit.oak.jcr package.
>> Michael
> Apparently because UserManagerImpl deals with nodes, but does want to
> set properties directly using the delegates. (Performance? Skipping checks?)

being able to set protected properties (currently this check
is missing but we will need to add it once the node type stuff
is implemented)... feel free to change the implementation of
SessionDelegate#getDelegate(Node jcrNode)... i didn't want to
use the method taking a path since i have the node at hand
already.... that looked really bad to me.

after all i am not convinced that the separation between delegate
and impl is really the right approach... to much duplicate
methods with no actual benefit IMO.


View raw message