jackrabbit-oak-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-16) Proper ValueFactory implementation and Value handling
Date Wed, 06 Jun 2012 13:58:23 GMT

    [ https://issues.apache.org/jira/browse/OAK-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290160#comment-13290160
] 

Jukka Zitting commented on OAK-16:
----------------------------------

bq. where should the check happen? oak-jcr or oak-core?

The check already exists in {{ValueHelper.convert()}}, it's just not effective since the relevant
{{PropertyDefinition.getRequiredType()}} call currently returns {{PropertyType.UNDEFINED}}
for all properties.
                
> Proper ValueFactory implementation and Value handling
> -----------------------------------------------------
>
>                 Key: OAK-16
>                 URL: https://issues.apache.org/jira/browse/OAK-16
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: jcr
>            Reporter: angela
>            Assignee: angela
>             Fix For: 0.3
>
>
> the GlobalContext contains the following code:
>         put(ValueFactory.class, new SimpleValueFactory());
> that doesn't work as the ValueFactory needs to be bound to each session instance
> in order to be able to deal with namespace mappings, paths, names etc....
> michi, just told me that in addition the ValueConverted needs some focus as well.
> and yesterday, i saw that Property#getType implementation in the jackrabbit-mikrokernel
> was not correct... 
> just to mention a few issues....

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message